Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 1863 by alexblate: Incorrect/Misleading error message from post-review CLI

*NOTE: Do not post confidential information in this bug report.*

What version are you running?

--> RBTools 0.2

What's the URL of the page containing the problem?


What steps will reproduce the problem?
1. (Perforce environment)
2. (Existing reviewboard ticket 12345 for p4 changelist 98765
3. Make source code changes, attempt to update ticket with these changes:
    > post-review.bat -r 12345

What is the expected output? What do you see instead?

I get the following message:

  Error uploading diff

  The generated diff file was empty. This usually means no files were
  modified in this change.

  Try running with --output-diff and --debug for more information.

  Your review request still exists, but the diff is not attached.

I thought this was odd. I checked my p4 environment settings. I checked that p4 diff returned the correct output. Everything was fine.

So, I tried again, this time with the changelist number, e.g.,

     > post-review.bat -r 12345 98765

And it worked properly.

After discussing with Christian, I realized that the issue was partially PEBCAK, in that in p4 I need only specify the changelist, not the reviewboard ticket number.

However, I think that in this case the CLI should either print a more sensible error message such as, "Please specify a changelist number" or should automagically use the existing changelist number from when the ticket was created.

What operating system are you using? What browser?

Windows 7, 64-bit, current updates as of 19 October 2010. Browser n/a.

Please provide any additional information below.


You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to
To unsubscribe from this group, send email to
For more options, visit this group at

Reply via email to