Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 1944 by mt02caro: post-review .reviewboardrc location calculation is not portable in windows
http://code.google.com/p/reviewboard/issues/detail?id=1944

What version are you running?
0.8

What's the URL of the page containing the problem?
-

What steps will reproduce the problem?
1. Put .reviewboardrc in %APPDATA% (for vista this is not "..\Local Settings\Application Data" (it doesn't exist) but something like "C:\Users\<user>\AppData\Roaming", which is not constant, ofcourse.
2. Use post-review and see if it loads the server url correctly.


What is the expected output? What do you see instead?
post-review should load .reviewboardrc from %APPDATA% and not %USERPROFILE%\Local Settings\Application Data

What operating system are you using? What browser?
Windows Vista

Please provide any additional information below.

To make post-review portable cross windows versions the homepath calculation in post-review.py::main should simply be the "APPDATA" environment variable. Perhaps leave the current calculation as a fallback.

A patch for this has been attached.

Attachments:
        post-review.patch  598 bytes

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.

Reply via email to