Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 1972 by douglas....@gmail.com: RBTools 0.3 deprecated API can't update existing review
http://code.google.com/p/reviewboard/issues/detail?id=1972

*NOTE: Do not post confidential information in this bug report.*

What version are you running?

RBTools 0.3
ReviewBoard 1.5.1
(SCM is Perforce)

What's the URL of the page containing the problem?


What steps will reproduce the problem?
1. create a review request
2. Attempt to update request with post-review

What is the expected output? What do you see instead?

400 error is produced rather than the update being submitted.

post-review isn't able to download the previous review, because
a %s substitution isn't performed.

Please provide any additional information below.

Patch to fix RBTools:

index c977908..c920f7e 100755
--- a/rbtools/postreview.py
+++ b/rbtools/postreview.py
@@ -670,7 +670,7 @@ class ReviewBoardServer(object):
         Returns the review request with the specified ID.
         """
         if self.deprecated_api:
-            url = 'api/json/reviewrequests/%s/'
+            url = 'api/json/reviewrequests/%s/' % (rid)
         else:
             url = '%s%s/' % (
self.root_resource['links']['review_requests']['href'], rid)



--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.

Reply via email to