Comment #15 on issue 1668 by chip...@gmail.com: Diffs not applying cleanly
circa 1.0.7 with odd line endings
I know your question is now a year old, but I missed it. Sorry :/
Basically, yes, you could in theory have post-review ask, but there's no
guarantee of getting it right. This is such a tricky problem and every fix
I've tried has caused new problems. I spent a great deal of time on this,
and researched how other tools solved it. To summarize: They haven't. At
least not when I was working on this last. There were bug reports and
complaints for other tools, all involving this same sort of issue, with no
I think what we need to do is just provide a better error response for
broken diffs. Allow the user to see the diff file itself and download it.
It may not be obvious that it's the line endings, but it's better than "The
patch doesn't apply."
As for this bug, I don't think there's anything we can do about it. People
should be careful about line endings :)
You received this message because you are subscribed to the Google Groups
To post to this group, send email to firstname.lastname@example.org.
To unsubscribe from this group, send email to
For more options, visit this group at