Status: New
Owner: ----
Labels: Type-Defect Priority-Medium
New issue 2225 by tstone2...@gmail.com: post-review does not with git work
in windows
http://code.google.com/p/reviewboard/issues/detail?id=2225
* NOTE: Do not post confidential information in this bug report. *
* If you need immediate support, please contact *
* reviewbo...@googlegroups.com *
What version are you running?
RBTools 0.3.2
and
post-review.py 0.7
What's the URL of the page containing the problem?
http://reviewboard.googlecode.com/svn/trunk/wxpostreview/postreview.py
What steps will reproduce the problem?
1.On a windows system, install RBTools 0.3.2
2.Make sure git.exe is in the path (and git --help works)
3.Make sure python os.system("git --help") works
3.In an existing git repository, run post-review
What is the expected output? What do you see instead?
Expected: "Unable to find a Review Board server for this source code tree"
Actual: "The current directory does not contain a checkout from a
supported source code repository."
What operating system are you using? What browser?
Windows 7 32 bit and Windows 7 64 bit
Please provide any additional information below.
in python, os.system("git --help") uses the path environment variable, so
the command works. subprocess.Popen, however, does not (by default). On
line 1020 of post-review.py, if you add shell=True, that will use the path
and find git. other than that, you would need a full git path. Attached
is a modified post-review.py that seems to work. It is based on the file
found at
http://reviewboard.googlecode.com/svn/trunk/wxpostreview/postreview.py (Aug
9 2011 @ 9 PM PST)
Attachments:
post-review.py 44.5 KB
--
You received this message because you are subscribed to the Google Groups
"reviewboard-issues" group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/reviewboard-issues?hl=en.
