Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 2278 by studog.c...@gmail.com: Review Board doesn't like patch that contains only line ending change
http://code.google.com/p/reviewboard/issues/detail?id=2278

What version are you running?  1.5.5


What's the URL of the page containing the problem?  The review request URL


What steps will reproduce the problem?
1. Check out source code file in svn
2. Edit with vim, notice that it is [dos] format
3. Change to [unix] and save
4. svn diff > line-ending.patch
5. Create review request, upload patch**
6. Publish request
7. Request has no patch attached

What is the expected output? What do you see instead?

The request should have the patch.

What operating system are you using? What browser?

**Patch is created on a linux box with svn 1.4.3 r23084. Review board is running from a different linux server, but, I am using it via Opera 11.51 on Win7 64 bit.

The patch is retrieved via a samba-exported view onto the svn server.

Please provide any additional information below.

Willing to test, within my capabilities; I am not the admin of the Review Board install.

Attached a quick cut-down version of the problem patch, but, I haven't tested this to see if it actually recreates the bug.

Attachments:
        review-board-line-endings.patch  422 bytes

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.

Reply via email to