Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 2420 by tif...@gmail.com: git --diff with binary patch looses "index ..." and "GIT binary patch" lines
http://code.google.com/p/reviewboard/issues/detail?id=2420

reviewboard 1.6.3

Take the following patch:
-----------
diff --git a/application.exe b/application.exe
index 08755e0dc70874dac727cd84ac7d0d0fe047ab63..bbc72b31473c94a4d28c0745bad6b62b478bc8cd
GIT binary patch
literal 524288
zc%1CLeOy%47C(H38DP{=M#V%WMI*(eA~A)A5?=;LK?lJZQ9&!UiL6X#)JlySD2~S|
...
-----------

When uploading it to reviewboard and downloading it again, it becomes:
-----------
diff --git a/application.exe b/application.exe
literal 524288
zc%1CLeOy%47C(H38DP{=M#V%WMI*(eA~A)A5?=;LK?lJZQ9&!UiL6X#)JlySD2~S|
...
-----------

=> The index hash and the "GIT binary patch" line are gone. The diff has become unusable.

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.

Reply via email to