Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 2435 by [RBTools] --repository-url option to post-review doesn't work

What version are you running?
Python 2.7
RBTools 0.3.4

The specific command-line causing the problem is:
post-review -o --target-groups=puppet --username=XXXXXX --password=XXXXXXXX --guess-description --guess-summary --repository-url=ssh://XXXXXXXXXX/repos/git/puppet.git

The actual problem in Humanese:
post-review without a --repository-url argument attempts to diff against the most recently added git remote
post-review with --repository-url specified crashes

Traceback (most recent call last):
File "/Library/Frameworks/Python.framework/Versions/2.7/bin/post-review", line 9, in <module>
    load_entry_point('RBTools==0.3.4', 'console_scripts', 'post-review')()
File "/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/rbtools/", line 3954, in main
    repository_info, tool = determine_client()
File "/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/rbtools/", line 3902, in determine_client
    repository_info = tool.get_repository_info()
File "/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/rbtools/", line 2857, in get_repository_info
    url = origin_url.rstrip('/')
UnboundLocalError: local variable 'origin_url' referenced before assignment

Code was introduced:

Code was committed with hash:

Additional information:
I have two remotes specified in my git repository. One remote "github/master" is a private github repo that I use to make sure my local git work is backed up in-between pushes to the real master. One remote "origin/master" which is the "real" master. That's where our reviewboard installation points to.

"origin/master" was the original remote created in .git/config via git clone.
"github/master" was created second using git remote add...

post-review w/o a --repository-url argument attempts to diff against github/master post-review with --repository-url=ssh://XXXXXXXXXX/repos/git/puppet.git crashes

You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to
To unsubscribe from this group, send email to
For more options, visit this group at

Reply via email to