Comment #2 on issue 2256 by seamus.l...@mformation.com: post-review should use -c option when calling svn diff with single rev
http://code.google.com/p/reviewboard/issues/detail?id=2256

Not quite, you need to support both cases, where single revision is listed and where a range is listed, so something like:

        # Otherwise, perform the revision range diff using a working copy
        else:

            # use -c if single rev supplied, else -r if range supplied
            revisions = revision_range.split(':')
            if len(revisions) == 1:
return (self.do_diff(["svn", "diff", "--diff-cmd=diff", "-c",
                                  revision_range],
                                 repository_info), None)
            else:
return (self.do_diff(["svn", "diff", "--diff-cmd=diff", "-r",
                                  revision_range],
                                 repository_info), None)


--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.

Reply via email to