Labels: Type-Defect Priority-Medium
New issue 2503 by roy.jean...@gmail.com: Check at beginning of login()
function in post-review 0.4 is wrong
What version are you running?
What's the URL of the page containing the problem?
What steps will reproduce the problem?
1. Call post-review with --username and --password.
What is the expected output? What do you see instead?
post-review fails with "Authentication information needs to be provided on
the command line when using --diff-filename=-".
This exit path is incorrectly taken because the check at the beginning of
the login() function has an operator precedence bug. It should be
if (options.diff_filename == '-' and
not (self.has_valid_cookie() or
(options.username and options.password))):
You received this message because you are subscribed to the Google Groups
To post to this group, send email to email@example.com.
To unsubscribe from this group, send email to
For more options, visit this group at