Comment #11 on issue 2359 by denis.ba...@gmail.com: Review creation fails with patches created with Subversion 1.7.x if they include a property change.
http://code.google.com/p/reviewboard/issues/detail?id=2359

Source of the problem is changed format of [svn diff] command, now it includes header for each changed directory while all RB-related code uses such headers as file header.

SVN 1.7.x format:
----8<--------8<--------8<--------8<--------8<--------8<--------8<----
Index: test-dir-props
===================================================================
--- test-dir-props      (revision 727867)
+++ test-dir-props      (working copy)

Property changes on: test-dir-props
___________________________________________________________________
Added: PROP-NAME
## -0,0 +1 ##
+PROP-VALUE
----8<--------8<--------8<--------8<--------8<--------8<--------8<----

Old SVN 1.6.x format:
----8<--------8<--------8<--------8<--------8<--------8<--------8<----
Property changes on: test-dir-props
___________________________________________________________________
Added: PROP-NAME
## -0,0 +1 ##
+PROP-VALUE
----8<--------8<--------8<--------8<--------8<--------8<--------8<----

I've attached simple script which you can use instead of [svn diff] command in working directory. Script calls [svn diff] by itself, cuts SVN 1.7.x extra directory headers and print result to stdout. You can grab/pipe it to file and then upload to ReviewBoard.

In case you use Subversion's pre-commit hook its easy to pass transaction's dirs-changed list to function strip_svn17x_extra_dirs_info() and then upload resulting diff to ReviewBoard. ATTENTION: you can call this function in hook after expanding all diff paths to absolute ones.

Attachments:
        cast-svn17x-diff-to-svn16x.py  3.0 KB

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.

Reply via email to