Labels: Type-Defect Priority-Medium
New issue 2567 by jon.bark...@gmail.com: Reviewboard replaces https with
http when getting files from hg repo
What version are you running?
What's the URL of the page containing the problem?
Issue is actually with posting a review
What steps will reproduce the problem?
1. Set up a mercurial repository through httpd, allowing only https traffic
(no http at all)
2. Add that repository to reviewboard, with the correct https url.
3. Attempt to add a diff, (in my case using hg postreview), and notice that
the reviewboard logs are attempting to fetch the file using http, not
https, and receiving a 404.
4. Finally, notice that your attempt to post a diff failed, and provided a
deceptive error message.
** bonus points: this behavior appears to be intentional, as seen in
reviewboard/scmtools/hg.py - where there is a line of code that explicitly
replaces https with http. I'm not sure about the rational that wanted that
behavior, but if someone still requires it, then an option toggling that
behavior should be added.
What is the expected output? What do you see instead?
Reviewboard should not change https to http, it should use what was
specified by the user.
What operating system are you using? What browser?
reviewboard is running on Fedora 10, python 2.5, and I'm running OS X 10.7,
using firefox 11.
Please provide any additional information below.
I commented out that line in get_file_http so that we can keep running. I
would hope for a better solution however.
You received this message because you are subscribed to the Google Groups
To post to this group, send email to email@example.com.
To unsubscribe from this group, send email to
For more options, visit this group at