Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 2585 by au...@google.com: Reviewboard's Mercurial Support won't work against Google Code
http://code.google.com/p/reviewboard/issues/detail?id=2585

What version are you running?
1.6.6

What's the URL of the page containing the problem?
N/A

What steps will reproduce the problem?
1. Use Mercurial on Project Hosting (Google Code)
2. Upload a diff

What is the expected output? What do you see instead?
I expect to be able to review diffs. Instead, I get a (baffling) error that the file doesn't exist in the parent revision.

You're going outside the Mercurial wireprotocol (understandable, since Mercurial lacks a way to fetch raw filecontent via the wireprotocol). I see you've already got a kludge in place for BitBucket (/raw/ instead of hgweb's /raw-file/), so maybe you can just add something similar for project hosting as well? The format you're looking for is http://${project}.googlecode.com/hg-history/${revision}/${filepath}.

I suspect you're broken against our git repositories as well if you do a similar trick against gitweb, although I didn't look. if you replace hg-history with git-history in the URL format I list above, you'll get what you'd expect.

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.

Reply via email to