Comment #4 on issue 2655 by Email being sent for comment with 0 character length

cancelling the first comment dialog shouldn't be creating a draft, so there should be nothing to publish, thus no email.

Correct. In fact the "publish" option should be made unavailable when the comment dialogue is made empty followed by a clock on "OK".

To simplify the reproduction, try this:
1) Open one review request.
2) Add one genuine comment
3) At some other line,
(i) click on "Add comment" at say line x, type something say 5 characters, click OK. (ii) The comment appears there on line x and the "publish" option is now visible. (iii) Now move at some other line say y, type something say 10 characters, click OK (iv) Now, delete all those 10 characters which are part of the comment at line y and click OK
   (v) Now click "publish"

As a result of publish, an email is generated. This email should only talk about the comment added at line x and it should not talk anything about comment that was attempted to be added at line y.

But in reality, the email would talk about comment added at line x with 5 characters and it will also indicate that comment was added at line y though with 0 characters!

Hope that helps.

You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to
To unsubscribe from this group, send email to
For more options, visit this group at

Reply via email to