Status: New
Owner: ----
Labels: Type-Defect Priority-Medium
New issue 2660 by nosov.si...@gmail.com: binary data is processed
improperly in svn, post-review
http://code.google.com/p/reviewboard/issues/detail?id=2660
* NOTE: Do not post confidential information in this bug report. *
* If you need immediate support, please contact *
* reviewbo...@googlegroups.com *
What version are you running?
RB 1.6.3
What's the URL of the page containing the problem?
HTTP POSTing to http://reviews.example.com/api/review-requests/178/diffs/:
{'
basedir': '/'}
What steps will reproduce the problem?
1. Say, we have two revisions. On the first revision we created the /trunc
directory. On the second revision we put icon.png into it and committed.
The diff will show smth like this:
Index: trunk/icon.png
===================================================================
--- trunk/icon.png (revision 1)
+++ trunk/icon.png (revision 2)
Property changes on: trunk/icon.png
___________________________________________________________________
Added: svn:mime-type
## -0,0 +1 ##
+application/octet-stream
\ No newline at end of property
2. Now we try to create a review with post-review.
post-review
What is the expected output? What do you see instead?
HTTP POSTing to
http://reviews.example.com/api/review-requests/176/diffs/:
{'basedir': '/'}
Got API Error 207 (HTTP code 400): The file was not found in the
repository
Error data: {u'stat': u'fail', u'file': u'/trunk/icon.png', u'err':
{u'msg': u'The file was not found in the repository', u'code': 207},
u'revision': u'1'}
Your review request still exists, but the diff is not attached.
What operating system are you using? What browser?
Firefox, Linux
Please provide any additional information below.
The output-diff is as follows:
Index: /trunk/icon.png
===================================================================
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: /trunk/icon.png
===================================================================
--- /trunk/icon.png (revision 1)
+++ /trunk/icon.png (revision 2)
Property changes on: trunk/icon.png
It would be ok if the commit contained only binary data, but is also
includes text information, so this makes inconvenient to get post-commit
reviews when a commit contains added binary data.
--
You received this message because you are subscribed to the Google Groups
"reviewboard-issues" group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/reviewboard-issues?hl=en.
