Comment #2 on issue 2707 by timw.at....@gmail.com: Unable to publish a review with comments on a screenshot
http://code.google.com/p/reviewboard/issues/detail?id=2707

The following workaround fixed it for me (which was enough to restore functionality for my users while a real fix is implemented):


diff --git a/reviewboard/htdocs/media/rb/js/reviews.js b/reviewboard/htdocs/media/rb/js/reviews.js
index 9888b4a..53e675b 100644
--- a/reviewboard/htdocs/media/rb/js/reviews.js
+++ b/reviewboard/htdocs/media/rb/js/reviews.js
@@ -1435,7 +1435,8 @@ $.reviewForm = function(review) {
         $(".comment-editable", dlg).each(function() {
             var editable = $(this);
             var comment = editable.data('comment');
-            var issueOpened = editable.next()[0].checked;
+            var issueOpened_ = editable.next()[0];
+            var issueOpened = issueOpened_ ? issueOpened_.checked : false;

             if (editable.inlineEditor("dirty") ||
                 issueOpened != comment.issue_opened) {


--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.

Reply via email to