Status: New
Owner: ----
Labels: Type-Defect Priority-Medium
New issue 2751 by [email protected]: Images with file names longer than 72
characters can not be properly uploaded as screenshots
http://code.google.com/p/reviewboard/issues/detail?id=2751
* NOTE: Do not post confidential information in this bug report. *
* If you need immediate support, please contact *
* [email protected] *
What version are you running?
1.6.12
What's the URL of the page containing the problem?
What steps will reproduce the problem?
1. Create an image with a file name that is 72 characters long (including
the extension)
2. Upload this file as a screenshot to review board
3. Publish this change
What is the expected output? What do you see instead?
Normally, a thumbnail of the screenshot shows up. Clicking the thumbnail
opens a page with the full screenshot. Instead, the thumbnail is blank and
the image on the next page is completely empty. See the attached files.
What operating system are you using? What browser?
Win7 64-bit
Chrome 22.0.1229.79
Please provide any additional information below.
It looks like the screenshot is stored like this:
image = models.ImageField(_("image"),
upload_to=os.path.join('uploaded', 'images',
'%Y', '%m', '%d'))
The django ImageField has a default max_length of 100, so when you take out
the "uploaded/images/2012/09/28/" that leaves about 72 characters. Which is
the length of the 68 character file name, plus the four character extension.
At the very least, users should be informed that an error has occurred and
no broken screenshots should be added. This error message could tell them
how they can avoid the problem (shortening the length of the file name).
Beyond that, it'd be great if this max_length could be increased.
Attachments:
full screenshot.PNG 7.8 KB
screenshot thumbnails.PNG 21.0 KB
--
You received this message because you are subscribed to the Google Groups
"reviewboard-issues" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/reviewboard-issues?hl=en.
