Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 2765 by waynejwe...@gmail.com: post-review does not use ~/.hgrc (post-review won't post)
http://code.google.com/p/reviewboard/issues/detail?id=2765

This issue (http://code.google.com/p/reviewboard/issues/detail?id=1708) has the same root cause.

I haven't been able to nail down why post-review doesn't use the users' hgrc, but I have figured out an interim solution. In utils/process.py, starting in line 68 you can modify it to:


    if split_lines:
        data = p.stdout.readlines()
        if ignore_errors:
            data = filter(lambda x: not x.startswith('Not trusting file'),
                          data)
    else:
        data = p.stdout.read()
        if ignore_errors:
data = '\n'.join(filter(lambda x: not x.startswith('Not trusting file'),
                             data.split('\n')))


And that will fix issues with 'Not trusting file' breaking commands that aren't looking for it. In my case it was breaking the very act of trying to post a review.

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.

Reply via email to