Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 2785 by zhangwen...@gmail.com: The post-review cannot create new review request for a svn working copy when I install both the svn client and the perforce client on my machine
http://code.google.com/p/reviewboard/issues/detail?id=2785

* NOTE: For customer support, please post to                     *
*       reviewbo...@googlegroups.com                             *
*                                                                *
*       Do not post confidential information in this bug report. *
*       If you need immediate support, please contact            *
*       reviewbo...@googlegroups.com                             *

What version are you running?
RBTools 0.4.2

What's the URL of the page containing the problem?
n/a

What steps will reproduce the problem?
1. Change the current directory to a svn working copy, make some change on a versioned file
2. Type post-review
3. Wait for a while, an error occurs.

What is the expected output? What do you see instead?
A new review quest should be created, but instead, error messages outputted:
Failed to execute command: ['p4', 'opened', '-c', 'default']
['Your session has expired, please login again.\n']

What operating system are you using? What browser?
Windows7, FireFox 16

Please provide any additional information below.
Seems the post-review checks the perforce client prior to the svn client, it picks up the perforce client even when the current directory is in a svn working copy.

When I used RBTools 0.3.4 before, it can create new review request in a svn working copy, seems it checks the svn client prior to the perforce client.

I expect that the post-review can select the correct SCM client when the current directory is inside a work copy of a SCM repo, or it can give me an option to explicitly specify the SCM client.

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.

Reply via email to