Status: New
Owner: ----
Labels: Type-Defect Priority-Medium
New issue 2797 by kch...@gmail.com: account preferences page fails silently
when using an auth backend that does not support timezone change
http://code.google.com/p/reviewboard/issues/detail?id=2797
* NOTE: For customer support, please post to *
* reviewbo...@googlegroups.com *
* *
* Do not post confidential information in this bug report. *
* If you need immediate support, please contact *
* reviewbo...@googlegroups.com *
What version are you running?
1.7beta2
What's the URL of the page containing the problem?
account/preferences/
What steps will reproduce the problem?
1. Set up a review board server with activedirectory auth backend (or any
other backend that does not have supports_change_timezone = True)
2. Login
3. Go to the account/preferences page
4. Change any setting and click "Save Preferences"
5. The save silently fails, and the form is displayed again with no visible
errors and no hint that it failed.
6. Go to a different page (such as the dashboard)
7. return to account/preferences
The setting(s) changed in step 4 have reverted.
What is the expected output? What do you see instead?
The changes should save.
What operating system are you using? What browser?
Chrome and IE8 on XP
Please provide any additional information below.
The timezone field of the account preferences form (accounts/forms.py:34)
is marked as required, but the template
(templates/accounts/prefs.html:39)does not display it if the auth backend
does not have supports_change_timezone=True
If the user tries to save changes to the preference page, the validation
fails because the timezone field is not present. The error is not visible
because the field is not rendered.
I worked around this by adding supports-change_timezone = True to the
ActiveDirectoryBackend class. (not sure if this breaks anything, but
timezone changes do appear to be working with this backend).
To fix for all backends regardless of capability, I suggest changing
timezone to be an optional field in PreferencesForm.
--
You received this message because you are subscribed to the Google Groups
"reviewboard-issues" group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/reviewboard-issues?hl=en.