Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 2812 by [email protected]: Layout of Git format patch file is corrupted sometime
http://code.google.com/p/reviewboard/issues/detail?id=2812

What version are you running?
1.6.13

What's the URL of the page containing the problem?
Download diff page

steps will reproduce the problem, but not always happen
1. using 'git format-patch' to generate patch
2. post review request
3. Jump 'Download diff' page to download. Sometime, layout is corrupted.
example:
From 9f4febefb3b0c188eb436675ea029c26490d517e Mon Sep 17 00:00:00 2001
From: xx <[email protected]>
Date: Fri, 30 Nov 2012 16:07:31 +0800
Subject: env: add a lib to read environment variables stored in flash

reference #210
Review-at: 628
Signed-off-by: xx <[email protected]>
---
 src/include/env.h               |   34 ++++++
 ...


sometime, layout will be:
diff --git a/src/lib/xx/Makefile b/src/lib/xx/Makefile
new file mode 100644
index 0000000..65aca64
--- /dev/null
...
From 9f4febefb3b0c188eb436675ea029c26490d517e Mon Sep 17 00:00:00 2001
From: xx <[email protected]>
Date: Fri, 30 Nov 2012 16:07:31 +0800
Subject: env: add a lib to read environment variables stored in flash

reference #210
Review-at: 628
Signed-off-by: xx <[email protected]>
---
 src/include/env.h               |   34 ++++++

Above example, I use '..' to represent some code snippet.







--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.

Reply via email to