Comment #18 on issue 46 by 80-column indicator in diff view

I'm not sure user customization makes sense (or at least, is as important as it is being considered). If code length is part of the review process, 'what length' is going to be a property of the project, not the reviewer. Ergo, the logical place for it to be configurable is as a repository attribute.

p.s. if you can rely on a fixed-width font, the CSS position of the margin can simply be specified in em units. If your DOM/CSS is sufficiently clever you can probably offload all the number crunching to the browser's render engine. (For that matter, if you *can't* rely on a fixed-width font, a margin is going to be ugly anyway, so...) An absolute position fixed-width div beneath the text but within the column element is probably sufficient.

You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to
To unsubscribe from this group, send email to
For more options, visit this group at

Reply via email to