Comment #2 on issue 2662 by rajas...@gmail.com: Repository List Resource web service API doesn't return all repos
http://code.google.com/p/reviewboard/issues/detail?id=2662

This seems to be a limit set in djblets/webapi/core.py:WebAPIResponsePaginated. Although the "links" array should point to the next page in case the total results is greater than what is requested, I agree with OP that if its requested, it should return all the records.

Can this line:

max_results = \
min(int(request.GET.get('max-results', default_max_results)),
                    max_results_cap)

be changed to
try:
    max_results = int(request.GET.get('max-results'))
except ValueError:
    max_results = default_max_results

We could remove the "max_results_cap" variable as well with the above change. From a performance standpoint, it could be an issue if we have lots of results obtained through the API.

Since the original design does provide a "next" url for pagination, that seems a decent solution as long as its documented.

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.

Reply via email to