Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 2885 by btho...@gmail.com: Hide whitespace changes toggle not working in diff viewer
http://code.google.com/p/reviewboard/issues/detail?id=2885

* NOTE: For customer support, please post to                     *
*       reviewbo...@googlegroups.com                             *
*                                                                *
*       Do not post confidential information in this bug report. *
*       If you need immediate support, please contact            *
*       reviewbo...@googlegroups.com                             *

What version are you running?
1.7.1

What's the URL of the page containing the problem?
Found on internal instance of ReviewBoard.

What steps will reproduce the problem?
1. View a diff that contains lines with only whitespace changes
2. Try to toggle 'Hide whitespace changes'
3.

What is the expected output? What do you see instead?
References to the whitespace changes should dim and whitespace changes should no longer be highlighted. Instead nothing happens and the button doesn't toggle.

Chrome's console shows:
Uncaught Error: Syntax error, unrecognized expression: ol.index a[href=#5.2]

What operating system are you using? What browser?
Windows 7/Mac OS X 10.8 Chrome/Firefox/Opera

Please provide any additional information below.
I've attached a patch that fixes the problem for me.

Attachments:
        whitespace_toggle.patch  594 bytes

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to