Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 2892 by New 4.3 RBTools path posting method is broken

What version are you running?
RBTools 0.4.3

What's the URL of the page containing the problem?
The post-review failed

What steps will reproduce the problem? a path-diff style diff with Perforce source control
  post-review //Depot/path/file.cpp@chgn1,@chgn2

What is the expected output? What do you see instead?
I wanted to post it, but it gives a traceback:
Traceback (most recent call last):
File "c:\Program Files (x86)\Python27\Scripts\", line 8,
in <module>
    load_entry_point('RBTools==0.4.3', 'console_scripts', 'post-review')()
File "c:\Program Files (x86)\Python27\lib\site-packages\rbtools-0.4.3-py2.7.egg\rbtools\", line 1308, in main
    diff, parent_diff = tool.diff(args)
File "c:\Program Files (x86)\Python27\lib\site-packages\rbtools-0.4.3-py2.7.egg\rbtools\clients\", line 284, in diff
    return self._path_diff(args)
File "c:\Program Files (x86)\Python27\lib\site-packages\rbtools-0.4.3-py2.7.egg\rbtools\clients\", line 408, in _path_diff
TypeError: _do_diff() takes at least 7 arguments (7 given)

What operating system are you using? What browser?

Please provide any additional information below.
The error is in the in the _path_diff method: the new_depot_path parameter is not created and not given to the _do_diff method.

See the _changenum_diff method, where it is created and given to the _do_diff.

A quick fix is to pass an empty string as the new fifth parameter of the _do_diff at the end of the _path_diff. It will work at least if there is no file move in the change.

You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
To post to this group, send email to
Visit this group at
For more options, visit

Reply via email to