Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 2909 by burhan....@triometric.net: Unable to upload a diff produced by "cvs rdiff". Produces "Unable to parse diff revision header ..." error
http://code.google.com/p/reviewboard/issues/detail?id=2909

*** For customer support, please post to reviewbo...@googlegroups.com
*** If you have a patch, please submit it to
http://reviews.reviewboard.org/
***
*** Do not post confidential information in this bug report!

What version are you running?
1.6.9

What's the URL of the page containing the problem?
/reviewboard/r/new/

What steps will reproduce the problem?
1. Generate a diff using "cvs rdiff -r <tag 1> -r <tag 2> <module>"

Here is an example file I generated to demonstrate the problem:

Index: cvstest/testfile
diff -u cvstest/testfile:1.22 cvstest/testfile:1.23
--- cvstest/testfile:1.22       Tue Feb 19 17:14:11 2013
+++ cvstest/testfile    Tue Feb 19 17:27:46 2013
@@ -9,7 +9,7 @@
 test
 test
 test
-another test
+test
 test
 test
 test

2. Create new review request.
3. Select the above file and click Upload.

What is the expected output? What do you see instead?

Expected result: File is uploaded and review process proceeds to the next step.

Actual result: An error message is shown:
Unable to parse diff revision header 'Tue Feb 19 17:14:11 2013'


What operating system are you using? What browser?
Fedora 16, Chrome.

Please provide any additional information below.

If I check out the second tag and do "cvs diff -r <tag 1>" then I get a diff that is usable by reviewboard, but it is of course cumbersome to have to do a checkout first.

Here is the same diff as earlier, generated in this way:

Index: testfile
===================================================================
RCS file: /vol/cvsroot/cvstest/testfile,v
retrieving revision 1.22
diff -u -r1.22 testfile
--- testfile    19 Feb 2013 17:14:11 -0000      1.22
+++ testfile    19 Feb 2013 17:27:18 -0000
@@ -9,7 +9,7 @@
 test
 test
 test
-another test
+test
 test
 test
 test


--
You received this message because this project is configured to send all issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to