Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 2954 by lamott...@gmail.com: Interdiffs include committed changes during review (specifically CVS, but this shouldn't matter)
http://code.google.com/p/reviewboard/issues/detail?id=2954

What version are you running?
1.7.6

What's the URL of the page containing the problem?
/r/1/diff/1-2/

What steps will reproduce the problem?
1. Post review for changes in sandbox
2. Other users commit changes
3. Update local sandbox and update diff on review
4. View interdiff, includes changes by other users

What is the expected output? What do you see instead?
Only differences between diffs.

What operating system are you using? What browser?
Mac.  Chrome.

Please provide any additional information below.
Is this the expected behavior?  If so, why?

Does it make sense to rely on patchutil's interdiff (assuming the current codebase does not)? Or re-implement the algorithm used there?

Interdiff is basically non-functional if the users keeps their sandbox up to date.

--
You received this message because this project is configured to send all issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to