Labels: Type-Defect Priority-Medium
New issue 2958 by ceesjan....@gmail.com: post-review with bzr crashes when
What version are you running?
Development versions of ReviewBoard+RBTools, checked out at 2013-04-19
What steps will reproduce the problem?
1. Enter a bazaar repository
2. Execute `post-review --revision-range=123..126`
What is the expected output? What do you see instead?
I get a stacktrace:
quinox@duivenkracht:~/projects/x/y ^2 $ post-review
==> HTTP Authentication Required
Enter authorization information for "Web API" at <codereview server>
Traceback (most recent call last):
File "/home/quinox/projects/tooling/usr/local/bin/post-review", line 3,
line 1292, in main
ValueError: too many values to unpack
Please provide any additional information below.
I solved it by patching rbtools/clients/bazaar.py:
@@ -85,7 +85,7 @@ class BazaarClient(SCMClient):
- return diff
+ return (diff, None)
def _get_range_diff(self, revision_range, files):
(Not uploading to your reviewboard because I wrote this patch by guessing,
I haven't looked at the code that calls this function)
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
You received this message because you are subscribed to the Google Groups
To unsubscribe from this group and stop receiving emails from it, send an email
To post to this group, send email to firstname.lastname@example.org.
Visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.