Status: New
Owner: ----
Labels: Type-Defect Priority-Medium
New issue 2967 by [email protected]: RBTools
http://code.google.com/p/reviewboard/issues/detail?id=2967
*** For customer support, please post to [email protected]
*** If you have a patch, please submit it to
http://reviews.reviewboard.org/
***
*** Do not post confidential information in this bug report!
What version are you running?
RBTools 0.5
What's the URL of the page containing the problem?
None
What steps will reproduce the problem?
1. 'rbt post' for subversion client will result in below code failure
TypeError: can only concatenate list (not "tuple") to list
What is the expected output?
Successful 'rbt post'
Please provide any additional information below.
Below is the code fix.
======================
sudhirbs@rhel-sudhirbs 0.5.0.1 $ svn diff
Index: clients/svn.py
===================================================================
--- clients/svn.py (revision 400024)
+++ clients/svn.py (working copy)
@@ -105,7 +105,7 @@
makes parent diffs possible, so we never return a parent diff
(the second value in the tuple).
"""
- return (self.do_diff(["svn", "diff", "--diff-cmd=diff"] + files),
+ return (self.do_diff(["svn", "diff", "--diff-cmd=diff"] +
list(files)),
None)
def diff_changelist(self, changelist):
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
You received this message because you are subscribed to the Google Groups
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.