Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 2970 by linkifyText(): URL parsing fails if URL is enclosed in XML-like tags

What version are you running?


What's the URL of the page containing the problem?

e.g., review-board/r/<change>

What steps will reproduce the problem?

1. Set description to contain a URL enclosed in pseudo-XML tags: <foo>http://bar/</foo>

What is the expected output? What do you see instead?

The description should contain a link to "http://bar/"; (with that highlighted)
Instead, I see a link to "http://bar/</foo" (with that highlighted).

What operating system are you using? What browser?

Chrome, either on Win7 or Arch Linux.

Please provide any additional information below.

It looks like this is due to linkifyText() immediately htmlEncode()ing the text before linkification: "http://bar/</foo" is not a particularly valid URL, but "http://bar/&lt;/foo"; is.

Perhaps the fix for this is to only htmlEncode() the text between matching URLs, and not the URLs themselves?

You received this message because this project is configured to send all issue notifications to this address.
You may adjust your notification preferences at:

You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
To post to this group, send email to
Visit this group at
For more options, visit

Reply via email to