Status: New
Owner: ----
Labels: Type-Defect Priority-Medium
New issue 2972 by [email protected]: post-review fails with Perforce
depot paths containing spaces in the default change list
http://code.google.com/p/reviewboard/issues/detail?id=2972
*** For customer support, please post to [email protected]
*** If you have a patch, please submit it to
http://reviews.reviewboard.org/
***
*** Do not post confidential information in this bug report!
What version are you running?
RBTools 0.5, Review Board 1.7.6
What's the URL of the page containing the problem?
N/A
What steps will reproduce the problem?
1. Check a file into Perforce with a space in the depot path, e.g.
//project/branch/Shared Code/foo/bar.txt
2. Open that Perforce file for edit and make sure it's in the default
change list
3. Make a change to the file so that there's something to diff
4. With post-review setup to work with your Perforce depot and Review Board
server, attempt to open a review: "post-review -o" (or "post-review -o
default")
What is the expected output? What do you see instead?
This should post a review with the file changes, but an error appears in
the Terminal:
Unsupported line from p4 opened: ... //project/branch/Shared -
What operating system are you using? What browser?
Mac OS X 10.7.x, Safari, Perforce server 2011.1
Please provide any additional information below.
As a workaround, paths with spaces do appear to be work in a numbered
changelist.
From the code, it potentially looks like the parsing of the "p4 opened"
command output is fragile, and could perhaps be marshaled instead. It also
looks like "p4 describe" is used with numbered changelists and the outputs
are in a slightly different format - not sure if that's the difference.
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
You received this message because you are subscribed to the Google Groups
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
