Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 2980 by pekka.t....@gmail.com: Diff viewer has problems with control characters
http://code.google.com/p/reviewboard/issues/detail?id=2980

*** For customer support, please post to reviewbo...@googlegroups.com
*** If you have a patch, please submit it to
http://reviews.reviewboard.org/
***
*** Do not post confidential information in this bug report!

What version are you running?
1.7.6

What's the URL of the page containing the problem?
-

What steps will reproduce the problem?
1. Create change in a file that contains Form Feed control character. Make the change BELOW the FF character.
2. Submit review request.

What is the expected output? What do you see instead?
ReviewBoard diff viewer highlites wrong row.

What operating system are you using? What browser?
ReviewBoard is running on Linux. Using Windows7 + Chrome for viewing review requests. Our source control system is SVN 1.7.8 (Windows).

Please provide any additional information below.

Our codebase is ancient. It seems to contain some control characters (besides CR and LF) for example in C source files. ReviewBoard diff viewer seems to struggle with them, I have so far identified at least Form Feed (FF) control character to cause problems. Change highliting gets displaced by one line per FF. When the FFs accumulate, the highlited part can get pretty far from the actual change. See attached picture. I also attached the actual diff.


Attachments:
        diff_viewer_form_feed_problem.png  9.4 KB
        svn_diff.txt  505 bytes

--
You received this message because this project is configured to send all issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to