Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 2984 by nano...@gmail.com: changing comment status when "edit review" before publishing will not update issue_status field
http://code.google.com/p/reviewboard/issues/detail?id=2984

*** For customer support, please post to reviewbo...@googlegroups.com
*** If you have a patch, please submit it to
http://reviews.reviewboard.org/
***
*** Do not post confidential information in this bug report!

What version are you running?
1.7.6

What's the URL of the page containing the problem?
review editor

What steps will reproduce the problem?
1. create a comment when viewing diff and check "Open an issue" and save this comment
+-----+-------------+--------+--------------+--------------+
| id  | text        | public | issue_status | issue_opened |
+-----+-------------+--------+--------------+--------------+
| 398 | new bug     |      0 | O            |            1 |
+-----+-------------+--------+--------------+--------------+

2. click on "Edit Review" in top green ruban, review editor will appear.
in review editor uncheck "Open an issue" box for the previous comment and save
issue_status remains to "O" and issue_opened moved to 0
+-----+---------+--------+--------------+--------------+
| id  | text    | public | issue_status | issue_opened |
+-----+---------+--------+--------------+--------------+
| 398 | new bug |      0 | O            |            0 |
+-----+---------+--------+--------------+--------------+

3. publish your review,
+-----+---------+--------+--------------+--------------+
| id  | text    | public | issue_status | issue_opened |
+-----+---------+--------+--------------+--------------+
| 398 | new bug |      1 | O            |            0 |
+-----+---------+--------+--------------+--------------+

What is the expected output?
+-----+---------+--------+--------------+--------------+
| id  | text    | public | issue_status | issue_opened |
+-----+---------+--------+--------------+--------------+
| 398 | new bug |      1 | NULL         |            0 |
+-----+---------+--------+--------------+--------------+

What do you see instead?
+-----+---------+--------+--------------+--------------+
| id  | text    | public | issue_status | issue_opened |
+-----+---------+--------+--------------+--------------+
| 398 | new bug |      1 | O            |            0 |
+-----+---------+--------+--------------+--------------+

What operating system are you using? What browser?
Linux ubuntu 12.04 for server, ubuntu 10.04 + chromium for client

I'm not sure it is safe to keep issue_status != NULL and issue_opened=0
In fact I do not see added value for issue_opened field, maybe there is one?


--
You received this message because this project is configured to send all issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to