Status: New
Owner: ----
Labels: Type-Defect Priority-Medium
New issue 2986 by bijan.va...@gmail.com: Posting paths in Perforce crashes
http://code.google.com/p/reviewboard/issues/detail?id=2986
*** For customer support, please post to reviewbo...@googlegroups.com
*** If you have a patch, please submit it to
http://reviews.reviewboard.org/
***
*** Do not post confidential information in this bug report!
What version are you running?
- ReviewBoard v1.7.6
- RBTools v0.5
What's the URL of the page containing the problem?
- Not a bug with ReviewBoard Web
- However, this has to do with using 'post-review' in RBtools to post paths
instead of changelists:
http://www.reviewboard.org/docs/manual/dev/users/tools/post-review/#posting-paths
What steps will reproduce the problem?
1. Submit files under a sample path
e.g. //depot/my/path/...
2. Attempt to create a review for the folder
e.g. post-review //depot/my/path/...
What is the expected output? What do you see instead?
The expected output is "Review #nnn posted"
The resulting output is a TypeError exception with the following stack
trace:
Traceback (most recent call last):
File "D:\Python27\Scripts\post-review-script.py", line 8, in <module>
load_entry_point('rbtools==0.5', 'console_scripts', 'post-review')()
File "D:\Python27\lib\site-packages\rbtools-0.5-py2.7.egg\rbtools\postreview.py",
line 1308, in main
File "D:\Python27\lib\site-packages\rbtools-0.5-py2.7.egg\rbtools\clients\perforce.py",
line 288, in diff
File "D:\Python27\lib\site-packages\rbtools-0.5-py2.7.egg\rbtools\clients\perforce.py",
line 412, in _path_diff
TypeError: _do_diff() takes at least 7 arguments (7 given)
What operating system are you using? What browser?
- Windows 7 Professional
- Google Chrome 27.0.1453.94 m
Please provide any additional information below.
(patch will be forthcoming...)
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
You received this message because you are subscribed to the Google Groups
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
