Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 3031 by gregie.b...@gmail.com: post-review tries to diff between the commited branch and master
http://code.google.com/p/reviewboard/issues/detail?id=3031

*** For customer support, please post to reviewbo...@googlegroups.com
*** If you have a patch, please submit it to
http://reviews.reviewboard.org/
***
*** Do not post confidential information in this bug report!

What version are you running?
RBTools 0.3.4

What steps will reproduce the problem?
1. have a repo with a master branch with some commits
2. add a new empty branch
3. add a commit to the new branch
4. post-review -p --server=http://reviewboard --guess-summary --guess-description --revision-range=$oldrev:$newrev --debug


What is the expected output? What do you see instead?
I expect post-review to only diff between the two relevant revisions. for some reason, part of what it does is this:
remote: >>> git merge-base master refs/heads/master
remote: >>> git branch -r --contains b41c522c1247254d7b5dc4fc24d25f9de50ad104 remote: >>> git diff --no-color --full-index --no-ext-diff 4d8fefd7d12d3009e58a645c2af41cd2e962fcd2..b41c522c1247254d7b5dc4fc24d25f9de50ad104 the 4d8fe commit is my master branch, for some reason post-review tries to diff it with b41c52, which is the branch i commited. the two branches have nothing in common, so it takes a long time for the diff to run.

What operating system are you using? What browser?
linux

Please provide any additional information below.
i tried playing with the --parent and --tracking-branch options.. to no avail.

--
You received this message because this project is configured to send all issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to