Status: New
Owner: ----
Labels: Type-Defect Priority-Medium
New issue 3108 by [email protected]: APIErrors return 403 but do not
log anything
http://code.google.com/p/reviewboard/issues/detail?id=3108
*** READ THIS BEFORE POSTING!
***
*** You must complete this form in its entirety, or your bug report will be
rejected.
***
*** For customer support, please post to [email protected]
***
*** If you have a patch, please submit it to
http://reviews.reviewboard.org/
***
*** Do not post confidential information in this bug report!
What version are you running?
1.7.14
What's the URL of the page containing the problem?
rbtools API call
What steps will reproduce the problem?
1. Add local user with the following permissions:
reviews | comment | Can add comment
reviews | review | Can add review
reviews | review request | Can change status
reviews | review request | Can submit as another user
sessions | session | Can add session
2. Get a given review request using RBClient
3. review.submit()
What is the expected output? What do you see instead?
Expected output is something meaningful in the server-side logs, such as:
"PUT /api/review-requests/6422/ by user <username> failed: 403 - user does
not have <name of permission>, cannot complete action"
Actual output is nothing - aside from the web server access log showing
403, nothing in the web server error log or the reviewboard log (set to
level Debug) gives any indication as to why this action failed.
What operating system are you using? What browser?
CentOS 6.3 on the server. No browser.
Please provide any additional information below.
I added a local user to use in a deploy script that automatically submits
reviews when they're merged to master. I gave the user the permissions
listed above. When I use RBTools (python client) to try to submit a review
request, I get back a traceback with:
rbtools.api.errors.APIError: You don't have permission for this (HTTP 403,
API Error 101)
However there's nothing in either the web server log or the ReviewBoard
debug-level log about this, either that there was a 403 API call, or any
specifics of why it happened. I'd really like to see at least a log that it
happened. With debug-level logging, I expect to see a message with the
details of what happened, as well as what permission the user is missing to
perform the required action.
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
You received this message because you are subscribed to the Google Groups
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/groups/opt_out.
