Comment #5 on issue 3034 by [email protected]: RBTools Mercurial client
ignore hgrc configuration file
http://code.google.com/p/reviewboard/issues/detail?id=3034
The current behavior of ignoring the hgrc is wrong for reasons beyond what
was reported in the initial report. There are valid scenarios where the
user's hgrc should be loaded.
For example, when I saw that RBTools was querying for the existence of a
special "reviewboard" path, I updated the custom Mercurial extension that
provides project-specific enhancements to automagically define this path.
To my surprise, RBTools wasn't picking up this path because that extension
wasn't being loaded because the hgrc was ignored! So much for easier
RBtools usage.
Furthermore, I'm using changeset evolution for Mercurial development. This
enables obsolescence (which isn't enabled by Mercurial by default). Now,
when RBTools queries my repos with obsolescence markers, Mercurial
complains about obsolescence not being enabled because the extension that
enables it isn't being loaded.
Not loading the repo's hgrc files is unexpected and thus wrong.
If RBtools needs consistent output from diff `hg diff`, it should specify
all the options in the command arguments. hg command-line arguments will
override values in hgrc files. Furthermore, it's possible to overwrite hgrc
values via the --config argument. This may be painful, but it needs to be
done in order for things to be "right." If this is too painful to do
manually, it might be worth writing a very basic Mercurial extension that
resets values in the [diff] section of the loaded config. RBTools can load
this extension via --config extensions.diffreset=/path/to/diffreset.py. The
Mercurial API for resetting config options has been stable for years, so
the extension approach should be relatively safe. I may author a patch
since I'm currently giving the Mercurial client some much needed love.
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
You received this message because you are subscribed to the Google Groups
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/groups/opt_out.
