Labels: Type-Defect Priority-Medium
New issue 3205 by dtsch...@vizrt.com: Closing review request does not add
the optional submission text to the ChangeDescription python instance.
What version are you running?
What's the URL of the page containing the problem?
What steps will reproduce the problem?
1.Create new review request.
2.Click on Close->Submitted
3.Enter some text in the edit field below "Describe the submission
4.Click on "OK"
What is the expected output? What do you see instead?
I expect that the text entered in the edit field is added as a description
to the ChangeDescription instance so that it can be retrieved on callbacks.
When I added some simple debugging logs, I see that no text is attached:
def close(self, type, user=None, description=None):
about line 830:
if type not in [self.SUBMITTED, self.DISCARDED]:
raise AttributeError("%s is not a valid close type" % type)
if self.status != type:
changedesc = ChangeDescription(public=True, text=description
changedesc.record_field_change('status', self.status, type)
if type == self.SUBMITTED:
self.public = True
self.status = type
logging.warn('SAVE DESCRIPTION SET RR:' + description)
logging.warn('SAVE RR:' + changedesc.text)
logging.warn('SAVE STACK:' + traceback.format_exc())
stacktrace in log:
WARNING:root:SAVE STACK:Traceback (most recent call last):
line 441, in __call__
request.method = 'POST'
AttributeError: can't set attribute
What operating system are you using? What browser?
Mozilla Firefox 26.0
Please provide any additional information below.
This information is required by a own written extension that connects on
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
You received this message because you are subscribed to the Google Groups
To unsubscribe from this group and stop receiving emails from it, send an email
To post to this group, send email to email@example.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/groups/opt_out.