Comment #9 on issue 3045 by saar.net...@gmail.com: when updating new diff
on existing reviews on reviewboard server in clearcase source file revision
is not LATEST
http://code.google.com/p/reviewboard/issues/detail?id=3045
Adding this issue rather opening a new one.
When trying to update an existing review with ClearCase changes while the
file is checkedout I'm getting the following output:
===================================================================================
post-review -r "134" --debug
RBTools 0.5.2
Python 2.6.6 (r266:84292, Jun 18 2012, 14:18:47)
[GCC 4.4.6 20110731 (Red Hat 4.4.6-3)]
Running on Linux-2.6.32-279.el6.x86_64-x86_64-with-centos-6.3-Final
Home = /users/saarn
Current Directory = /vobs/build
Checking the repository type. Errors shown below are mostly harmless.
DEBUG:root:Checking for a Subversion repository...
DEBUG:root:Running: svn info build --non-interactive
DEBUG:root:Command exited with rc 1:
['svn', 'info', 'build', '--non-interactive']
svn: '.' is not a working copy
---
DEBUG:root:Checking for a Git repository...
DEBUG:root:Running: git rev-parse --git-dir
DEBUG:root:Command exited with rc 128: ['git', 'rev-parse', '--git-dir']
fatal: Not a git repository (or any of the parent directories): .git
---
DEBUG:root:Checking for a Mercurial repository...
DEBUG:root:Checking for a CVS repository...
DEBUG:root:Checking for a Perforce repository...
DEBUG:root:Checking for a Plastic repository...
DEBUG:root:Checking for a ClearCase repository...
DEBUG:root:Running: cleartool pwv -short
DEBUG:root:Running: diff --version
DEBUG:root:Running: cleartool lsview -full -properties -cview
DEBUG:root:Running: cleartool describe -short vob:.
DEBUG:root:Running: cleartool pwv -root
DEBUG:root:repository info: Path: /vobs/build, Base path: /vobs/build,
Supports changesets: False
Finished checking the repository type.
HTTP GETting api/info/
DEBUG:root:Running: cleartool lscheckout -all -cview -me
-fmt %En\t%PVn\t%Vn\n
DEBUG:root:Running: diff -uN
/vobs/build/tst/file@@/main/fortis/hamsa/izabo/TestReviewBoard/2
/vobs/build/tst/file
DEBUG:root:Command exited with rc 1:
['diff', '-uN', '/vobs/build/tst/file@@/main/fortis/hamsa/izabo/TestReviewBoard/2', '/vobs/build/tst/file']
--- /vobs/build/tst/file@@/main/fortis/hamsa/izabo/TestReviewBoard/2
2014-02-17 16:26:24.154092000 +0200
+++ /vobs/build/tst/file 2014-02-17 16:39:23.611353000 +0200
@@ -31,3 +31,17 @@
fsdfsdsdfsdf
+
+
+
+34
+32
+4
+234
+23
+4
+324
+32
+4
+23
+added by saar to test updating existing review
---
DEBUG:root:Running: cleartool describe -fmt %On
/vobs/build/tst/file@@/main/fortis/hamsa/izabo/TestReviewBoard/2
DEBUG:root:Running: cleartool describe -fmt %On /vobs/build/tst/file
HTTP GETting api/
HTTP GETting http://review-board/api/info/
Using the new web API
HTTP GETting http://review-board/api/review-requests/134/
DEBUG:root:Running: cleartool lsvob -long /vobs/build
DEBUG:root:Repository's /vobs/build uuid
is '87701b00.c21e11d5.b323.00:e0:18:1c:4c:3b'
HTTP GETting http://review-board/api/repositories/
HTTP GETting http://review-board/api/repositories/4/
HTTP GETting http://review-board/api/repositories/4/info/
DEBUG:root:Matching repository
uuid:87701b00.c21e11d5.b323.00:e0:18:1c:4c:3b with
path:/view/izabo-ReviewBoard/vobs/build
DEBUG:root:repository info: Path: /view/izabo-ReviewBoard/vobs/build, Base
path: /view/izabo-ReviewBoard/vobs/build, Supports changesets: False
Uploading diff, size: 388
HTTP POSTing to http://review-board/api/review-requests/134/diffs/:
{'basedir': u'/view/izabo-ReviewBoard/vobs/build'}
Review request #134 posted.
http://review-board/r/134/
====================================================================================
When checking-in the file and running the following command I'm getting the
following output:
====================================================================================
post-review -r "134"
--revision-range "/view/izabo.TestReviewBoard-saarn/vobs/build/tst/file@@/main/fortis/hamsa/izabo/TestReviewBoard/2;/view/izabo.TestReviewBoard-saarn/vobs/build/tst/file@@/main/fortis/hamsa/izabo/TestReviewBoard/3"
--debug
RBTools 0.5.2
Python 2.6.6 (r266:84292, Jun 18 2012, 14:18:47)
[GCC 4.4.6 20110731 (Red Hat 4.4.6-3)]
Running on Linux-2.6.32-279.el6.x86_64-x86_64-with-centos-6.3-Final
Home = /users/saarn
Current Directory = /vobs/build/tst
Checking the repository type. Errors shown below are mostly harmless.
DEBUG:root:Checking for a Subversion repository...
DEBUG:root:Running: svn info build --non-interactive
DEBUG:root:Command exited with rc 1:
['svn', 'info', 'build', '--non-interactive']
svn: '.' is not a working copy
---
DEBUG:root:Checking for a Git repository...
DEBUG:root:Running: git rev-parse --git-dir
DEBUG:root:Command exited with rc 128: ['git', 'rev-parse', '--git-dir']
fatal: Not a git repository (or any of the parent directories): .git
---
DEBUG:root:Checking for a Mercurial repository...
DEBUG:root:Checking for a CVS repository...
DEBUG:root:Checking for a Perforce repository...
DEBUG:root:Checking for a Plastic repository...
DEBUG:root:Checking for a ClearCase repository...
DEBUG:root:Running: cleartool pwv -short
DEBUG:root:Running: diff --version
DEBUG:root:Running: cleartool lsview -full -properties -cview
DEBUG:root:Running: cleartool describe -short vob:.
DEBUG:root:Running: cleartool pwv -root
DEBUG:root:repository info: Path: /vobs/build, Base path: /vobs/build,
Supports changesets: False
Finished checking the repository type.
HTTP GETting api/info/
DEBUG:root:Running: diff -uN
/view/izabo.TestReviewBoard-saarn/vobs/build/tst/file@@/main/fortis/hamsa/izabo/TestReviewBoard/2
/view/izabo.TestReviewBoard-saarn/vobs/build/tst/file@@/main/fortis/hamsa/izabo/TestReviewBoard/3
DEBUG:root:Command exited with rc 1:
['diff', '-uN', '/view/izabo.TestReviewBoard-saarn/vobs/build/tst/file@@/main/fortis/hamsa/izabo/TestReviewBoard/2', '/view/izabo.TestReviewBoard-saarn/vobs/build/tst/file@@/main/fortis/hamsa/izabo/TestReviewBoard/3']
---
/view/izabo.TestReviewBoard-saarn/vobs/build/tst/file@@/main/fortis/hamsa/izabo/TestReviewBoard/2
2014-02-17 16:26:24.154092000 +0200
+++
/view/izabo.TestReviewBoard-saarn/vobs/build/tst/file@@/main/fortis/hamsa/izabo/TestReviewBoard/3
2014-02-17 16:48:20.451286000 +0200
@@ -31,3 +31,17 @@
fsdfsdsdfsdf
+
+
+
+34
+32
+4
+234
+23
+4
+324
+32
+4
+23
+added by saar to test updating existing review
---
DEBUG:root:Running: cleartool describe -fmt %On
/view/izabo.TestReviewBoard-saarn/vobs/build/tst/file@@/main/fortis/hamsa/izabo/TestReviewBoard/2
DEBUG:root:Running: cleartool describe -fmt %On
/view/izabo.TestReviewBoard-saarn/vobs/build/tst/file@@/main/fortis/hamsa/izabo/TestReviewBoard/3
HTTP GETting api/
HTTP GETting http://review-board/api/info/
Using the new web API
HTTP GETting http://review-board/api/review-requests/134/
DEBUG:root:Running: cleartool lsvob -long /vobs/build
DEBUG:root:Repository's /vobs/build uuid
is '87701b00.c21e11d5.b323.00:e0:18:1c:4c:3b'
HTTP GETting http://review-board/api/repositories/
HTTP GETting http://review-board/api/repositories/4/
HTTP GETting http://review-board/api/repositories/4/info/
DEBUG:root:Matching repository
uuid:87701b00.c21e11d5.b323.00:e0:18:1c:4c:3b with
path:/view/izabo-ReviewBoard/vobs/build
DEBUG:root:repository info: Path: /view/izabo-ReviewBoard/vobs/build, Base
path: /view/izabo-ReviewBoard/vobs/build, Supports changesets: False
Uploading diff, size: 498
HTTP POSTing to http://review-board/api/review-requests/134/diffs/:
{'basedir': u'/view/izabo-ReviewBoard/vobs/build'}
Review request #134 posted.
http://review-board/r/134/
====================================================================================
In both cases, the review 134 is not updated with the changes (see attached
screen shot) it is looking at Revision
/main/fortis/hamsa/izabo/TestReviewBoard/1 against the new changes, while
there are already revisions 2 and 3
Is this a bug or am I doing something wrong?
Attachments:
reviewboardissue.JPG 67.7 KB
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
You received this message because you are subscribed to the Google Groups
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/groups/opt_out.
