Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 3267 by hackagad...@gmail.com: The 'visible' checkbox in review groups does not do anything
http://code.google.com/p/reviewboard/issues/detail?id=3267

*** READ THIS BEFORE POSTING!
***
*** You must complete this form in its entirety, or your bug report will be
rejected.
***
*** For customer support, please post to reviewbo...@googlegroups.com
***
*** If you have a patch, please submit it to
http://reviews.reviewboard.org/
***
*** Do not post confidential information in this bug report!


What version are you running?
1.7.4

What's the URL of the page containing the problem?
/reviewboard/r/<reviewid>

What steps will reproduce the problem?
1. In the Admin dashboard, create a review group, check the 'Visible' checkbox and check the 'Invite only' checkbox
2. Create a review assigned to the review group created in step 1.
3. Log out
4. Select the 'All Review Requests' link
5. Select the review that was created in step 2.

What is the expected output? What do you see instead?
The review should have been displayed, instead the following was displayed:
---
You don't have access to this review request.

This review request is private. You must be a requested reviewer, either directly or on a requested group, and have permission to access the repository in order to view this review request.
---

What operating system are you using? What browser?
Server OS: FreeBSD 10.0

Client OS: MacOS X Mavericks
Browsers:
Safari 7.0.1
Firefox 27.0.1

Please provide any additional information below.
It seems that reviewboard/reviews/models.py fetches the 'visible' boolean value, but does not use it in the is_accessible_by() method.

The following attached patch seems to fix the issue.


Attachments:
        fix-visibility.patch  527 bytes

--
You received this message because this project is configured to send all issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to