Comment #3 on issue 3273 by rbt post with git-svn and --parent diffs traces back


That code should almost certainly be removed. Doing so just pushed the traceback to a different part of the code though (as make_svn_diff will return None, and I don't believe there is any error handling around that cases). I think there are some underlying issues that need to be clarified, like:

Do svn repositories support diffs with parentdiffs? If so, we'll need to update the git client to generate a svn parent diff in a way that RB will understand. If not, 'rbt post' from a git-svn checkout probably shouldn't support the --parent flag as I presently understand it.

You received this message because this project is configured to send all issue notifications to this address.
You may adjust your notification preferences at:

You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
To post to this group, send email to
Visit this group at
For more options, visit

Reply via email to