Comment #3 on issue 3273 by walt.jav...@gmail.com: rbt post with git-svn and --parent diffs traces back
http://code.google.com/p/reviewboard/issues/detail?id=3273

David,

That code should almost certainly be removed. Doing so just pushed the traceback to a different part of the code though (as make_svn_diff will return None, and I don't believe there is any error handling around that cases). I think there are some underlying issues that need to be clarified, like:

Do svn repositories support diffs with parentdiffs? If so, we'll need to update the git client to generate a svn parent diff in a way that RB will understand. If not, 'rbt post' from a git-svn checkout probably shouldn't support the --parent flag as I presently understand it.

--
You received this message because this project is configured to send all issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Reply via email to