Status: New
Owner: ----
Labels: Type-Enhancement Priority-Medium

New issue 3316 by nlasso...@landmarkglobal.com: Don't email yourself
http://code.google.com/p/reviewboard/issues/detail?id=3316

*** For customer support, please post to reviewbo...@googlegroups.com
*** If you have a patch, please submit it to
http://reviews.reviewboard.org/
***
*** Do not post confidential information in this enhancement request!


What version are you running?

2.0 RC2

What's the URL of the page this enhancement relates to, if any?

/r/*

Describe the enhancement and the motivation for it.

I'm tired of getting emails when I submit a comment or a request. I did the action, ReviewBoard shouldn't email me, it should only email everyone else.

What operating system are you using? What browser?

All

Please provide any additional information below.

I implemented this for my system. It requires the following changes:

In admin/forms.py, add this to the EMailSettingsForm:

    mail_do_not_send_to_self = forms.BooleanField(
label=_("Exclude the person doing the action when review emails are sent"),
        required=False)


In notifications/email.py, add this to send_review_mail

    if siteconfig.get("mail_do_not_send_to_self"):
        if (from_email in recipients):
            recipients.remove(from_email)

        if (from_email in to_field):
            to_field.remove(from_email)

before these lines:

    # Set the cc field only when the to field (i.e People) are mentioned,
    # so that to field consists of Reviewers and cc consists of all the
    # other members of the group
    if to_field:
        cc_field = recipients.symmetric_difference(to_field)



--
You received this message because this project is configured to send all issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Reply via email to