Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 3320 by rbt with --include for multiple directories/files doesn't seem to work

*** You must complete this form in its entirety, or your bug report will be
*** For customer support, please post to
*** If you have a patch, please submit it to
*** Do not post confidential information in this bug report!
This is for with SVN repo. post-review used to allow multiple directories with
$ post-review dir1 [dir2]

Not working with rbt:
$ rbt --include dir1 --include dir2

The problem seem to be indentation problem on line "diff_cmd.extend(files)". Un-indent seems to fixed it.

What version are you running?
RB 1.7.16, rbt 0.6

What's the URL of the page containing the problem?

What steps will reproduce the problem?
1. rbt --debug --include dir1 --include dir2

What is the expected output? What do you see instead?
Running: svn diff --diff-cmd=diff --notice-ancestry -r BASE
rbtools.commands.CommandError: There don't seem to be any diffs!

What operating system are you using? What browser?
Centos 6.4

Please provide any additional information below.

--- rbtools/clients/      2014-04-07 15:21:06.000000000 -0700
+++ rbtools/clients/     2014-04-30 13:54:24.000000000 -0700
@@ -255,7 +255,7 @@
                 # Working copy--do a normal range diff
                 diff_cmd.extend(['-r', '%s:%s' % (base, tip)])

-            diff_cmd.extend(files)
+        diff_cmd.extend(files)

         if self.history_scheduled_with_commit(changelist):
             svn_show_copies_as_adds = getattr(

You received this message because this project is configured to send all issue notifications to this address.
You may adjust your notification preferences at:

You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
To post to this group, send email to
Visit this group at
For more options, visit

Reply via email to