Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 3334 by e.smolen...@gmail.com: RBTools - GNU diff check should check for Solaris
http://code.google.com/p/reviewboard/issues/detail?id=3334

*** READ THIS BEFORE POSTING!
***
*** You must complete this form in its entirety, or your bug report will be
rejected.
***
*** For customer support, please post to reviewbo...@googlegroups.com
***
*** If you have a patch, please submit it to
http://reviews.reviewboard.org/
***
*** Do not post confidential information in this bug report!


What version are you running?
RBTools 0.6

What's the URL of the page containing the problem?
n/a

What steps will reproduce the problem?
1. On a Solaris system try to run rbt post with gdiff installed.
2.
3.

What is the expected output? What do you see instead?
Expect a new review request to be created. Instead the following error is shown:
GNU diff is required in order to generate diffs.

What operating system are you using? What browser?
Solaris

Please provide any additional information below.
On a Solaris system, GNU diff is installed as gdiff. The checks.py module should check for Solaris and use the correct binary name as it does in perforce.py

if hasattr(os, 'uname') and os.uname()[0] == 'SunOS':
    diff_cmd = "gdiff"
else:
    diff_cmd = "diff"


--
You received this message because this project is configured to send all issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Reply via email to