Labels: Type-Defect Priority-Medium
New issue 3334 by e.smolen...@gmail.com: RBTools - GNU diff check should
check for Solaris
*** READ THIS BEFORE POSTING!
*** You must complete this form in its entirety, or your bug report will be
*** For customer support, please post to reviewbo...@googlegroups.com
*** If you have a patch, please submit it to
*** Do not post confidential information in this bug report!
What version are you running?
What's the URL of the page containing the problem?
What steps will reproduce the problem?
1. On a Solaris system try to run rbt post with gdiff installed.
What is the expected output? What do you see instead?
Expect a new review request to be created. Instead the following error is
GNU diff is required in order to generate diffs.
What operating system are you using? What browser?
Please provide any additional information below.
On a Solaris system, GNU diff is installed as gdiff. The checks.py module
should check for Solaris and use the correct binary name as it does in
if hasattr(os, 'uname') and os.uname() == 'SunOS':
diff_cmd = "gdiff"
diff_cmd = "diff"
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
You received this message because you are subscribed to the Google Groups
To unsubscribe from this group and stop receiving emails from it, send an email
To post to this group, send email to email@example.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.