Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 3356 by smsm...@gmail.com: "Diff currently unavailable" when reviewing change to file that is not pushed to remote repo yet
http://code.google.com/p/reviewboard/issues/detail?id=3356

What version are you running?

1.7.20 of RB, RBTools 0.5.5, RBTools 0.6

What's the URL of the page containing the problem?

http://rb.example.com/r/123/diff/

What steps will reproduce the problem?
1. Create and check in a file with some text foo
2. git mv foo bar
3. commit
4. rbt post
5. edit bar
6. commit
7. rbt post --revision-range=HEAD^:HEAD

What is the expected output? What do you see instead?

I expected to see the changes to bar, but instead I get:
Diff currently unavailable.
Error: The file 'bar' (r123abc)  could not be found in the repository.

What operating system are you using? What browser?

rbt was running on a Mac and I'm viewing with Chrome, but I hope these don't matter.

Please provide any additional information below.

The backtrace indicates that RB is trying to fetch a file from the remote repository (in this case, a github instance) but the file is not there. That's expected; the git mv commit has not been pushed yet. rbt post would need to get the base file from the local repository.

Traceback (most recent call last):
File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.20.dev-py2.7.egg/reviewboard/diffviewer/views.py", line 251, in view_diff_fragment
    diff_file = get_requested_diff_file()
File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.20.dev-py2.7.egg/reviewboard/diffviewer/views.py", line 171, in get_requested_diff_file
    populate_diff_chunks(files, highlighting, request=request)
File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.20.dev-py2.7.egg/reviewboard/diffviewer/diffutils.py", line 342, in populate_diff_chunks
    chunks = generator.get_chunks()
File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.20.dev-py2.7.egg/reviewboard/diffviewer/chunk_generator.py", line 137, in get_chunks
    large_data=True)
File "/usr/local/lib/python2.7/dist-packages/Djblets-0.7.27-py2.7.egg/djblets/util/misc.py", line 157, in cache_memoize
    data = lookup_callable()
File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.20.dev-py2.7.egg/reviewboard/diffviewer/chunk_generator.py", line 136, in <lambda>
    lambda: list(self._get_chunks_uncached()),
File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.20.dev-py2.7.egg/reviewboard/diffviewer/chunk_generator.py", line 141, in _get_chunks_uncached
    old = get_original_file(self.filediff, self.request)
File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.20.dev-py2.7.egg/reviewboard/diffviewer/diffutils.py", line 126, in get_original_file
    request=request)
File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.20.dev-py2.7.egg/reviewboard/scmtools/models.py", line 171, in get_file
    large_data=True)[0]
File "/usr/local/lib/python2.7/dist-packages/Djblets-0.7.27-py2.7.egg/djblets/util/misc.py", line 157, in cache_memoize
    data = lookup_callable()
File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.20.dev-py2.7.egg/reviewboard/scmtools/models.py", line 170, in <lambda>
    request)],
File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.20.dev-py2.7.egg/reviewboard/scmtools/models.py", line 263, in _get_file_uncached
    base_commit_id=base_commit_id)
File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.20.dev-py2.7.egg/reviewboard/hostingsvcs/github.py", line 301, in get_file
    raise FileNotFoundError(path, revision)

--
You received this message because this project is configured to send all issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Reply via email to