Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 3384 by Content-Disposition is "inline" instead of "attachment" in response to Download Diff

What version are you running? 1.7.21

What's the URL of the page containing the problem? e.g. /r/12345/diff/raw/

What steps will reproduce the problem?
1. Use Chrome, click "Download Diff".
2. Note that the response headers contain: Content-Disposition: inline; filename=some.patch 3. Chrome displays the diff inline, as instructed. The file should be downloaded instead. I think Content-Disposition: attachment;filename=some.patch should achieve this.

What is the expected output? What do you see instead?

Patch contents are displayed in the browser window. For Download Diff, it should ... download.

What operating system are you using? What browser?

Chrome.  Firefox is not affected.

Please provide any additional information below.

See also discussion at!topic/reviewboard/yhW3ycXwqVA

You received this message because this project is configured to send all issue notifications to this address.
You may adjust your notification preferences at:

You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
To post to this group, send email to
Visit this group at
For more options, visit

Reply via email to