Status: New
Owner: ----
Labels: Type-Defect Priority-Medium
New issue 3393 by [email protected]: Interdiffs are incorrect when new
files are added
http://code.google.com/p/reviewboard/issues/detail?id=3393
*** READ THIS BEFORE POSTING!
***
*** You must complete this form in its entirety, or your bug report will be
rejected.
***
*** For customer support, please post to [email protected]
***
*** If you have a patch, please submit it to
http://reviews.reviewboard.org/
***
*** Do not post confidential information in this bug report!
What version are you running?
v2.0.1
What's the URL of the page containing the problem?
http://<server>/r/3529/diff/1-2/
What steps will reproduce the problem?
1. Start with a Subversion-backed repository.
2. Make a change that involves adding a new file and editing several
existing files.
3. Create a patch file with "svn diff" and use it to create a new review
request.
4. Make a one-line change to the new file (and nothing else). Create a new
patch file and add it to the review.
5. View the interdiff between patches 1 and 2.
What is the expected output? What do you see instead?
I expected that the interdiff would only show the small change that was
made in step 4 (this is what Review Board v1.x would do). Instead, the new
file is shown in red as "reverted" and the interdiff shows a bunch of
changes that aren't part of the second patch.
What operating system are you using? What browser?
Windows 7, on both IE11 and Firefox 29.
Please provide any additional information below.
When viewing diff 1 and diff 2 individually, they display as expected.
When downloading the diffs to view offline, both appear as expected
(diff-ing the diffs shows that there is indeed only a one-line change
between them). The only problem is when viewing the interdiff between
them. The extraneous changes that show up in the interdiff appear to be
changes that were made in patch 1, applied in reverse. The files
containing extraneous changes have "Diff Revision 2 - File Reverted" in the
header bar.
I attempted to create a review on reviews.reviewboard.org to demonstrate
the issue, but it didn't reproduce. It may have something to do with our
setup using a Subversion repository instead of git.
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
You received this message because you are subscribed to the Google Groups
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.
