Comment #6 on issue 3312 by bruce.c...@gmail.com: Diffs without embedded commit IDs can not be used
http://code.google.com/p/reviewboard/issues/detail?id=3312

Sorry - I just installed 2.0.1 and found that uploading the same diff *does* work - it shows 'Revision UNKNOWN' but still works. So it's not something that's changed between 2.0.1 and 2.0.2

The hg postreview code handles git diffs by adding a header:

        if opts.get('git') or ui.configbool('diff', 'git'):
# Git diffs don't include the revision numbers with each file, so
            # we have to put them in the header instead.
            output += "# Node ID " + node.hex(r.node()) + "\n"
            output += "# Parent  " + node.hex(parent.node()) + "\n"




--
You received this message because this project is configured to send all issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Reply via email to