Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 3426 by nick.ind...@gmail.com: "Didn't apply patch cleanly"
http://code.google.com/p/reviewboard/issues/detail?id=3426

What version are you running?
2.0.1

What's the URL of the page containing the problem?
r/[number]/diff

What steps will reproduce the problem?
1. Click "Update diff" on existing review request
2. Upload the new diff
3. Try to view the diff

What is the expected output? What do you see instead?
Expecting to see the diff, instead see an error saying:

The patch to '[filename]' didn't apply cleanly. The temporary files have been left in '/tmp/reviewboard.[id]' for debugging purposes. `patch` returned:

This may be a bug in the software, a temporary outage, or an issue with the format of your diff.

What operating system are you using? What browser?
Windows, reviewboard running on a linux server. Viewing in Chrome.

Please provide any additional information below.
This is similar to issue #3398. I took a look at the .rej and .diff files in the temp folder--they look almost identical. If I try to patch locally with the diff file, it works just fine.

If I take a look at my apache error logs, I see something like:
Warning:root:Attempting to override delete count on FileDiffData [hash] from 16 to None (FileDiff None)

--
You received this message because this project is configured to send all issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Reply via email to