Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 3556 by Problem with 'rbt diff' and empty files in RBTools 0.6.2

From the mailing list, 2014/07/22:

There's a problem with the empty files detection code in at least the Mercurial client of RBTools 0.6.2: it's adding all the empty files that exist in the repository. The relevant code is in, _handle_empty_files():

        tip_empty_files = self._get_files_in_changeset(tip, get_empty=True)
        added_empty_files = tip_empty_files - base_files

base_empty_files = self._get_files_in_changeset(base, get_empty=True)
        deleted_empty_files = base_empty_files - tip_files

        if not (added_empty_files or deleted_empty_files):
            return diff

From debugging I've done, added_empty_files and deleted_empty_files were both the same, and contained the list of empty files that were already in the repository.
base_files and tip_files looked correct.

You received this message because this project is configured to send all issue notifications to this address.
You may adjust your notification preferences at:

You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
To post to this group, send email to
Visit this group at
For more options, visit

Reply via email to